Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace flag expose_internals to expose-internals #32542

Closed
wants to merge 1 commit into from
Closed

test: replace flag expose_internals to expose-internals #32542

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

They are the same, but --expose-internals seems to be the standard, actually, the written on src/node_options.h file, and by the way, --expose_internals flag is not documented anywhere.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 29, 2020
@juanarbol juanarbol force-pushed the juanarbol/replace-expose_internals-flag branch from efebb61 to ecb7abf Compare March 29, 2020 05:44
@juanarbol juanarbol changed the title test: rename flag expose_internals to expose-internals test: replace flag expose_internals to expose-internals Mar 29, 2020
@cjihrig
Copy link
Contributor

cjihrig commented Mar 29, 2020

by the way, --expose_internals flag is not documented anywhere.

It sort of is: https://nodejs.org/api/cli.html#cli_options

@juanarbol
Copy link
Member Author

It sort of is: https://nodejs.org/api/cli.html#cli_options

I'm blind 🤦‍♂️

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30171/ (:yellow_heart:)

@sam-github
Copy link
Contributor

No strong feelings on this PR, but note that using a mixture of _ and - in the tests, while it seems inconsistent, has a side-effect of ensuring that both continue to be supported (as documented).

@jasnell
Copy link
Member

jasnell commented Mar 29, 2020

@sam-github ... if we're concerned about that, then there should be a separate dedicated test that ensures that both _ and - options work correctly.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 29, 2020 •
edited
Loading

There is test/parallel/test-cli-node-options.js.

EDIT: Specifically these lines:

node/test/parallel/test-cli-node-options.js

Lines 26 to 27 in cd1db2d

expect('--no-warnings', 'B\n');
expect('--no_warnings', 'B\n');

@juanarbol
Copy link
Member Author

juanarbol commented Mar 29, 2020 •
edited
Loading

I think I can add a test for both flags.

@juanarbol juanarbol mentioned this pull request Mar 29, 2020
Closed
3 tasks
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@juanarbol @addaleax
test: replace flag expose_internals to expose-internals
7534477 
PR-URL: #32542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 7534477

@addaleax addaleax closed this Apr 2, 2020
Trott pushed a commit that referenced this pull request Apr 6, 2020
@juanarbol @Trott
test: check that --expose-internals is disallowed in NODE_OPTIONS
0826935 
Add test cases that confirm that `--expose-internals` and
`--expose_internals` are disallowed in the NODE_OPTIONS environment
variable.

PR-URL: #32554
Refs: #32542
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: replace flag expose_internals to expose-internals
397489e 
PR-URL: #32542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: check that --expose-internals is disallowed in NODE_OPTIONS
5f01fed 
Add test cases that confirm that `--expose-internals` and
`--expose_internals` are disallowed in the NODE_OPTIONS environment
variable.

PR-URL: #32554
Refs: #32542
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: replace flag expose_internals to expose-internals
edf35db 
PR-URL: #32542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: check that --expose-internals is disallowed in NODE_OPTIONS
8c68dd4 
Add test cases that confirm that `--expose-internals` and
`--expose_internals` are disallowed in the NODE_OPTIONS environment
variable.

PR-URL: #32554
Refs: #32542
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
test: check that --expose-internals is disallowed in NODE_OPTIONS
b0386b4 
Add test cases that confirm that `--expose-internals` and
`--expose_internals` are disallowed in the NODE_OPTIONS environment
variable.

PR-URL: #32554
Refs: #32542
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@juanarbol @targos
test: replace flag expose_internals to expose-internals
10fa362 
PR-URL: nodejs#32542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@juanarbol @targos
test: replace flag expose_internals to expose-internals
8eb6807 
PR-URL: #32542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
@juanarbol juanarbol deleted the juanarbol/replace-expose_internals-flag branch January 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juanarbol @cjihrig @nodejs-github-bot @sam-github @jasnell @addaleax @Trott @targos